Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deny unsafe math operations #303

Closed
5 tasks
Tracked by #300
sam0x17 opened this issue Apr 8, 2024 · 0 comments · Fixed by #485
Closed
5 tasks
Tracked by #300

deny unsafe math operations #303

sam0x17 opened this issue Apr 8, 2024 · 0 comments · Fixed by #485
Assignees
@keithtensor
Labels
enhancement New feature or request

Comments

@sam0x17
Copy link
Contributor

sam0x17 commented Apr 8, 2024

Part of #300, we need to deny the ability to perform potentially-panicking and/or overflowing operations on number types in subtensor

AC:

  • fix existing offending overflow operations
  • fix existing offending float usages, if any
  • enforce #[deny(arithmetic_overflow)]
  • enforce clippy::integer_arithmetic
  • disallow the use of f32 / f64 entirely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithtensor keithtensor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ban unsafe arithmetic operations opentensor/subtensor
2 participants
@sam0x17 @keithtensor