Improve documentation and logging messages. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhui
reviewed
Jun 22, 2017
src/agent/border_agent.hpp
Outdated
| * This method updates the file descriptor sets with file descriptors used by border agent. | ||
| * | ||
| * @param[inout] aReadFdSet A reference to the read file descriptors. | ||
| * @param[inout] aWriteFdSet A reference to the write file descriptors. |
There was a problem hiding this comment.
Thanks. Fixed this and other missing ones. Also changed a little Doxyfile.in to fix some unnecessary warnings.
jwhui
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the comments and logging messages. Also adjusted some variable names.