Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[low-power] retransmission frame CSL IE handling #6286

Closed
brianljt opened this issue Mar 16, 2021 · 2 comments · Fixed by #6342
Closed

[low-power] retransmission frame CSL IE handling #6286

brianljt opened this issue Mar 16, 2021 · 2 comments · Fixed by #6342
Assignees

Comments

@brianljt
Copy link
Contributor

Describe the bug
Retransmission frame with CSL IE included has wrong MIC which causes retransmission failure.

To Reproduce

  1. Start OT1.2 router
  2. Start OT1.2 child(mode -)
  3. Enable CSL on the child
  4. Ping from child to the router

Expected behavior
If retransmission happens, retransmitted frame should not change the content of the frame. However, in current implementation, the CSL IE is updated while MIC not updated. This leads to the router rejects the retransmission frames.

IEEE Std 802.15.4 - 6.7.4.3 Retransmission,

When not using TSCH mode and a frame with the Security Enabled field set to one is retransmitted, the
frame shall be retransmitted without changes and without passing through the outgoing frame security
procedure, as defined in 9.2.1.

@brianljt
Copy link
Contributor Author

This issue is fixed in PR #6275. However, without updating the CSL IE, the retransmission frame will update the router with incorrect CSL phase info. Need to add counter measure to this.

@brianljt
Copy link
Contributor Author

Example sniffer log, retransmission frame has incorrect MIC as CSL IE is updated.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant