Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken OT 1.2 support in openthread/ot-nrf528xx #148

Closed
George-Stefan opened this issue Sep 2, 2021 · 2 comments · Fixed by #149
Closed

Broken OT 1.2 support in openthread/ot-nrf528xx #148

George-Stefan opened this issue Sep 2, 2021 · 2 comments · Fixed by #149
Assignees

Comments

@George-Stefan
Copy link

It looks like for retransmissions of a frame with CSL IE and security enabled are corrupted.
Since the CSL IE phase is updated after the frame was secured.

See nrf_802154_tx_started() from https://github.com/openthread/ot-nrf528xx/blob/main/src/src/radio.c#L1216

@edmont
Copy link
Member

edmont commented Sep 3, 2021

Hi @George-Stefan, thanks for spotting this. This PR should fix it: #149

Please notice that even after the fix the CSL IEs will be outdated for the retransmitted frames. This is a known issue and Thread Group is currently discussing a proper approach to address it.

@edmont
Copy link
Member

edmont commented Sep 3, 2021

In any case OpenThread has a workaround already for the out of sync issue: openthread/openthread#6342

@jwhui jwhui linked a pull request Sep 4, 2021 that will close this issue
@jwhui jwhui closed this as completed in #149 Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants