Skip to content

Commit

Permalink
Fix typo on daily reward, from addItemId to addU16 (#371)
Browse files Browse the repository at this point in the history
  • Loading branch information
@dudantas
dudantas committed May 3, 2022
1 parent 8686cd9 commit 9da46a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion data/modules/scripts/daily_reward/daily_reward.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ function Player.readDailyReward(self, msg, currentDay, state)
local itemType = ItemType(itemId)
local itemName = itemType:getArticle() .. " " .. itemType:getName()
local itemWeight = itemType:getWeight()
msg:addItemId(itemId)
msg:addU16(itemId)
msg:addString(itemName)
msg:addU32(itemWeight)
end
Expand Down

2 comments on commit 9da46a7

@lucasgrizante
Copy link
Contributor

@lucasgrizante lucasgrizante commented on 9da46a7 May 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, another bug:

May 03 18:00:59 instance-20220216-1801 canary[3222673]: scriptInterface: [Modules Interface]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: scriptId: [data/modules/scripts/daily_reward/daily_reward.lua:onRecvbyte]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: timerEvent: []
May 03 18:00:59 instance-20220216-1801 canary[3222673]:  callbackId:[]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: function: []
May 03 18:00:59 instance-20220216-1801 canary[3222673]: error [data/modules/scripts/daily_reward/daily_reward.lua:462: attempt to call field 'getItemIdByClientId' (a nil value)
May 03 18:00:59 instance-20220216-1801 canary[3222673]: stack traceback:
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         [C]: in function 'getItemIdByClientId'
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         data/modules/scripts/daily_reward/daily_reward.lua:462: in function 'selectDailyReward'
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         data/modules/scripts/daily_reward/daily_reward.lua:200: in function <data/modules/scripts/daily_reward/daily_reward.lua:194>]

@dudantas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, another bug:

May 03 18:00:59 instance-20220216-1801 canary[3222673]: scriptInterface: [Modules Interface]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: scriptId: [data/modules/scripts/daily_reward/daily_reward.lua:onRecvbyte]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: timerEvent: []
May 03 18:00:59 instance-20220216-1801 canary[3222673]:  callbackId:[]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: function: []
May 03 18:00:59 instance-20220216-1801 canary[3222673]: error [data/modules/scripts/daily_reward/daily_reward.lua:462: attempt to call field 'getItemIdByClientId' (a nil value)
May 03 18:00:59 instance-20220216-1801 canary[3222673]: stack traceback:
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         [C]: in function 'getItemIdByClientId'
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         data/modules/scripts/daily_reward/daily_reward.lua:462: in function 'selectDailyReward'
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         data/modules/scripts/daily_reward/daily_reward.lua:200: in function <data/modules/scripts/daily_reward/daily_reward.lua:194>]

Open a issue, please.

Please sign in to comment.