Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounts SendOutfits #2540

Closed
2 of 5 tasks
eightbites opened this issue Apr 14, 2024 · 6 comments
Closed
2 of 5 tasks

Mounts SendOutfits #2540

eightbites opened this issue Apr 14, 2024 · 6 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@eightbites
Copy link

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

In some tests I did, I noticed that, from the commit before the commit that adds the 13.32 protocol, the mounts when you open the custom outfit are not selected, but from the commit that adds the 13.32 protocol to the current main when you open the custom outfits the mount is marked and you can't give it ok unless you uncheck the mount option

COMMIT BEFORE 13.32:
2168c7ca-6712-4af9-9160-df04e435f565

COMMIT FROM 13.32 ONwards:
WhatsApp Image 2024-04-14 at 12 03 07

notice that in the first photo the mount is unmarked when you open the customise outfit, in the second photo the mount is marked when you open the customise outfits, I don't know how to solve this if someone is willing to solve it it will help the community a lot

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@eightbites eightbites added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 14, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Apr 14, 2024
@eightbites
Copy link
Author

When I remove this function in protocolgame.cpp it works normally but the store mounts do not appear, it only shows the ones that the player actually has: else if (mount->type == "store") {
msg.add<uint16_t>(mount->clientId);
msg.addString(mount->name, "ProtocolGame::sendOutfitWindow - mount->name");
msg.addByte(0x01);
msg.add<uint32_t>(0x00);
++mountSize;
}

@eightbites
Copy link
Author

@dudantas consegue verifica isso pra nos ?

@eightbites
Copy link
Author

@elsongabriel consegue ver ?

@eightbites
Copy link
Author

vi que o problema nao é no cliente 13.32, pos fiz um teste logando no cliente 13.30 e ta o mesmo problema

@elsongabriel
Copy link
Contributor

@elsongabriel consegue ver ?

i'll check.

@elsongabriel
Copy link
Contributor

elsongabriel commented May 1, 2024

Closing this issue, because we already have this same issue opened with more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants