Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npc sam shop item discrepancies #2632

Closed
2 of 5 tasks
aboogesnickle opened this issue May 14, 2024 · 5 comments · Fixed by #2685
Closed
2 of 5 tasks

fix: npc sam shop item discrepancies #2632

aboogesnickle opened this issue May 14, 2024 · 5 comments · Fixed by #2685
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@aboogesnickle
Copy link

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

There are several items that are buy only that should be sellable as well as missing sell items.

What OS are you seeing the problem on?

Linux, Windows, MacOS

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aboogesnickle aboogesnickle added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 14, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels May 14, 2024
@aboogesnickle
Copy link
Author

I have already fixed this in my local repo, but I don't have permission to push the branch and I have no clue how to add a branch besides doing a git push.

@majestyotbr
Copy link
Contributor

I have already fixed this in my local repo, but I don't have permission to push the branch and I have no clue how to add a branch besides doing a git push.

Only maintainers and collaborators can create branchs in the repository.
If you want to contribute, create a fork.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo

@aboogesnickle
Copy link
Author

aboogesnickle commented May 15, 2024

I figured it out, and I think I have a PR for it. If I need to do something else let me know.

@elsongabriel
Copy link
Contributor

I figured it out, and I think I have a PR for it. If I need to do something else let me know.

see youtube, how to create fork, create branch, and open a pr.

@FelipePaluco
Copy link
Contributor

#2685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants