Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests on generated files. #164

Open
cube2222 opened this issue Jan 15, 2024 · 3 comments
Open

Add e2e tests on generated files. #164

cube2222 opened this issue Jan 15, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cube2222
Copy link
Contributor

This issue is two-fold.

The main point is that we should, after generating static registry files, spin up a local http server to mock the registry, and run some e2e tofu executions with it, to make sure it's working well.

This should be executed on generated files prior to syncing them to the prod bucket, and ideally also on each pull request.

@janosdebugs janosdebugs added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request labels Jan 17, 2024
@kislerdm
Copy link
Contributor

@cube2222 Hey Kuba, I'd be happy to give a hand with the issue this week.

@cube2222
Copy link
Contributor Author

Apologies for the late response, are you still interested in taking this @kislerdm?

Also, just to clarify the issue a bit more, the end to end tests should be very limited. One or two executions using some modules like local file. The goal is for this to not slow down the sync workflow too much.

The http server would ideally also be something simple off-the-shelf, like nginx serving on localhost. But if it’s not easy to do, it could also be a simple go binary.

@virtualroot
Copy link
Contributor

virtualroot commented Mar 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants