merge accelerators #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n # print error to STDERR\n echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n"; |
There was a problem hiding this comment.
I think it is a good idea to call pod deintegrate before commiting the changes so the code in the repo is "free" from cocoapods modification
|
Started to do some reviews, but relized that this PR was not about reviewing the code of the old accelerator packs we had so I removed those comments. Just left one about the |
rperezcubero
approved these changes
Nov 11, 2020
|
Thanks, ill run the |
* add new projects to travis file * update README * remove old sample repo
rperezcubero
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
TODO: Update README
TODO: Update travis.yml
See #66
What's in this pull request?
This PR brings in the TextChat and Annotation Accelerators into the Core project. It is quite a big PR but you can review commit by commit. The first two commits are mainly copying in the text chat and annotation projects. Below is a screenshot of the project structure. The sample projects and test targets have been copied over with the source files for the accelerators under the core folder.