Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] LibPandaDNA Support #32

Closed
EndangeredNayla opened this issue Feb 18, 2021 · 2 comments
Closed

[Discussion] LibPandaDNA Support #32

EndangeredNayla opened this issue Feb 18, 2021 · 2 comments

Comments

@EndangeredNayla
Copy link

Description

Reupload of #29 since I derped the description.

I am requesting the ability for the level editor to completely bypass non open source components and the ability to use LibPandaDNA to launch the editor similar to the scope of Chris's Project Toon Express.

My biggest pet pieve is this is the Open Level Editor and LibDisney is not open source, but is Visible Source. I believe all open source components should be used if possible. With the codebase of LibDisney being leaked / shared to the public maybe it could be used to understand the code better to help finish the issue on LibPandaDNA's side.

@EndangeredNayla EndangeredNayla added the enhancement New feature or request label Feb 18, 2021
@chrisd149
Copy link
Contributor

The main issue I ran into using Libpandadna to launch the editor was the lack of a couple of components (mainly DNASignText.) I believe the missing components have since been added to the original libpandadna repo and could be rigged to work with the level editor. I'm not sure how much effort/refracturing it would take, but from my own attempt at it, it looks like it could work.

@drewc5131
Copy link
Collaborator

drewc5131 commented Feb 23, 2021

Again, this sounds like a complete waste of time considering that the original disney code (but modernized to work with panda 1.10+ and python 3) is just as easy to compile as libpandadna, and libpandadna is being phased out in favor of original disney code (e.g. toontown offline), and ttoffline is the only really relevant game that used libpandadna. (i exclude clash due to it being an old heavily modified python version of libpandadna that is internally very different)

I'll leave this open for discussion but the reality is, libpandadna would be the project that needs updating for compatibility in order to add all missing features that are required, since libpandadna is explicitly coded to be a drag and drop replacement for libtoontown, so all of the functions and components should line up now, but if anything else is missing, thats on them, not the editor.

@drewc5131 drewc5131 changed the title [Enhancement] LibPandaDNA Support [Discussion] LibPandaDNA Support Mar 16, 2021
@drewc5131 drewc5131 removed the enhancement New feature or request label Mar 16, 2021
@OpenToontownTools OpenToontownTools locked and limited conversation to collaborators Apr 21, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants