Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPaint Brushes ignore alpha channel on Raster levels #2376

Open
artisteacher opened this issue Nov 11, 2018 · 10 comments
Open

MyPaint Brushes ignore alpha channel on Raster levels #2376

artisteacher opened this issue Nov 11, 2018 · 10 comments
Labels

Comments

@artisteacher
Copy link
Contributor

artisteacher commented Nov 11, 2018

Issue Summary

When using the mypaint brushes on a Raster level, if the style’s opacity is lowered in the style editor, the mypaint brushes completely ignore the set alpha value. This is not the case for Toonz Raster levels with the same brushes.

Expected Results

For the alpha channel set in the style editor to change the opacity when using the mypaint brushes for both level types.

Actual Results

Mypaint brushes respect the alpha channel only on Toonz Raster levels

System Information

  • OpenToonz Version: most recent nightly build
  • Operating System: MacOS 10.14 & 10.13.6
  • CPU:
  • Memory:
  • Graphics Card:
  • Graphics Tablet:
@artisteacher
Copy link
Contributor Author

Does this happen in Windows & Linux too, or is it just a MacOS problem?

@RodneyBaker
Copy link
Collaborator

Reference #2257 as a Work In Progress implementation of MyPaint Brushes with Toonz raster levels.

@RodneyBaker RodneyBaker changed the title Raster brushes ignore alpha channel on Raster levels (WIP MyPaint / Toonz Raster) Brushes ignore alpha channel Dec 3, 2018
@RodneyBaker RodneyBaker changed the title (WIP MyPaint / Toonz Raster) Brushes ignore alpha channel (WIP) MyPaint / Toonz Raster Brushes ignore alpha channel Dec 27, 2018
@RodneyBaker
Copy link
Collaborator

Please note this is an ongoing work in progress with additional enhancement to Mypaint brushes in Toonz raster levels anticipated in the 2019 development cycle.

This report also should be reviewed in light of recent additions to include Matte Color for image formats that lack alpha channels as that might resolve some related issues.

@RodneyBaker RodneyBaker added this to In progress in 2020 UI Scrub Sep 8, 2019
@RodneyBaker RodneyBaker moved this from In progress to Staging in 2020 UI Scrub Sep 8, 2019
@RodneyBaker RodneyBaker moved this from Staging to Unresolved in 2020 UI Scrub Sep 8, 2019
@RodneyBaker RodneyBaker removed this from Unresolved in 2020 UI Scrub Sep 21, 2019
@artisteacher
Copy link
Contributor Author

@RodneyBaker - the problem is not Toonz Raster my paint brushes - which are expected to have only partial my paint implementation. Toonz raster my paint brushes respect the Style editor's alpha channel. The problem is that standard Raster level my paint brushes ignore the alpha channel from the style editor. Personally I think this is a bug and should stay open.

@artisteacher artisteacher changed the title (WIP) MyPaint / Toonz Raster Brushes ignore alpha channel (WIP) MyPaint Brushes ignore alpha channel on Raster levels Jan 9, 2020
@artisteacher artisteacher changed the title (WIP) MyPaint Brushes ignore alpha channel on Raster levels MyPaint Brushes ignore alpha channel on Raster levels Jan 9, 2020
@manongjohn manongjohn reopened this Jan 9, 2020
@gab3d
Copy link
Contributor

gab3d commented Jan 9, 2020

@artisteacher
With your most recent comment I've just understood what this issue is all about.
I confirm this happens in Windows also.

I don't see it as a bug really, but I do feel something should be done UI wise to let users understand how OT works with regard to Raster levels and Opacity.

The fact seems to be that OT is only taking into consideration the RGB values of the selected color in the Raster Drawing Palette (and not the Alpha value).
I guess this is because in Raster levels the Brush Tool has its own Opacity values in the Tool Options Bar:

  • Opacity Min / Max for standard brushes.
  • Opacity for MyPaint brushes. (besides each brush Settings panel having Opacity, Opacity multiply, and Opacity linearize options as well). See Manual section for reference.

In light of this, there don't seem to be a bug in here.
Nevertheless it'd be good to unable the Alpha value and slider from the Style Editor (or not showing it altogether), while in Raster Drawing Palette, so not to confuse users. 👍

@manongjohn
Copy link
Collaborator

I've reopened it but not listing as a Bug or an Enhancement.

Leave it open as it is an issue since there is an inconsistancy for the same brush against 2 different levels which in my opinion would classify as a potential bug.

@manongjohn
Copy link
Collaborator

We need to be careful of marking things as Enhancements and then closing them (per our current policy) as some may be potential bugs or issues that need to be addressed and incorrectly marking them and closing them will not give it the attention it might require.

Though this begs further discussion in a different thread, I dislike the practice of closing Feature Requests/Enhancements unless it will never be done (in which case it should be marked as Won't Do) or it's it's been resolved.

Again...Out of Sight, Out of Mind....anything that gets Closed is essentially given the kiss of death as it will, in all likelihood, be ignored.

@RodneyBaker
Copy link
Collaborator

I dislike the practice of closing Feature Requests/Enhancements

As far as I can tell you are the primary developer who just needs to say, "keep Feature Requests open" and it's done. Most of the people who made the policy for closing feature requests aren't currently active developers.

@ghost
Copy link

ghost commented May 15, 2020

I'm going to label this as a bug just to find things quickly. Is that ok?

@ghost ghost added bug and removed bug labels May 15, 2020
@ghost ghost added bug and removed bug labels May 15, 2020
@manongjohn
Copy link
Collaborator

As I stated previously, this us a potential bug so I have no issues with labeling it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants