Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag to switch node port order not working #2550

Open
gab3d opened this issue Mar 10, 2019 · 9 comments
Open

Drag to switch node port order not working #2550

gab3d opened this issue Mar 10, 2019 · 9 comments
Labels

Comments

@gab3d
Copy link
Contributor

gab3d commented Mar 10, 2019

Issue Summary

In the OpenToonz Manual ir reads:
"In the FXs that accept multiple input nodes it is possible to change the stacking order of the input nodes by clicking and dragging in ports area."
https://opentoonz.readthedocs.io/en/latest/applying_special_fx.html#transparency

...this seems to not be working currently and could be a good time saver!

Steps to Reproduce

In a node that has multiple inputs, and they are already connected to other nodes.
Drag from one node input port to another port of the same node.

Expected Results

To switch the connected nodes order.

Actual Results

Nothing... 😄

System Information

  • OpenToonz Version: 1.3
  • Operating System: Windows
@WolfInABowl
Copy link

This is what is being described, is it this that is not working correctly?
Input Swizzle

@artisteacher
Copy link
Contributor

I think it depends on the FX. I can get that to work for the Over FX node - but not everything. It definitely does not work for Matte nodes...

@gab3d
Copy link
Contributor Author

gab3d commented Mar 10, 2019

@WolfInABowl
yes, that same thing.

Now I see it works in the Over fx (it worked for me too), could you please try it on any of the following effects?:

  • Over Ino
  • Matte In
  • Art Contour
  • External Palette
  • Glow
  • Warp
  • Bokeh Iwa

...basically I couldn't find any other fx node where this works, but the Over node.

@artisteacher
Copy link
Contributor

It partially works for a particle node. It seems to me that it only works when you are changing between the same port type - ie. texture to texture or control to control. It won't work when trying to switch from texture to control, source to matte or etc.

Ideally, you should be able to switch input this way no matter what you are changing between.

@gab3d
Copy link
Contributor Author

gab3d commented Mar 10, 2019

@artisteacher
mmm... 🤔 in the Over Ino it doesn't work and the ports are of the same type.

@artisteacher
Copy link
Contributor

Nope - foreground vs background.

@gab3d
Copy link
Contributor Author

gab3d commented Mar 10, 2019

...while testing what @artisteacher said about "switching partially working" in particle nodes, I saw another strange thing happening there when you try to switch between a Texture and a Control port:

  • the ports seem to get connected theirselves (a vertical connection line shows between the two) and the previously connected nodes seem to get disconnected (I stress "seem" because if you delete one of the nodes that was previously connected to one of those ports the port gets connected to another node automatically). :trollface:

Now, I realized that if you click on the Reorder Nodes button, the connection lines show again (and the switch was never performed).
So there must be a drawing/update issue in the Schematic, and switching between Texture and Control ports don't work for particle nodes.

@gab3d
Copy link
Contributor Author

gab3d commented Mar 10, 2019

@artisteacher

Nope - foreground vs background.

you mean the actual visible name of the ports has to be identical for this to work?

@artisteacher
Copy link
Contributor

you mean the actual visible name of the ports has to be identical for this to work?

That's what I think - or at least that when the name is different there are likely structural differences to the code that prevent it from working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants