Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brush Tool - Last used settings not saved on preset selection. #2757

Closed
melieconiek opened this issue Sep 7, 2019 · 3 comments · Fixed by #2770
Closed

Brush Tool - Last used settings not saved on preset selection. #2757

melieconiek opened this issue Sep 7, 2019 · 3 comments · Fixed by #2770

Comments

@melieconiek
Copy link
Contributor

Issue Summary

The last used brush settings are not saved when updated by selecting a brush preset--only when the brush setting controls are manipulated. Affects all three level types.

Steps to Reproduce

Manipulate one of the controls on the brush tool's option bar. Select a brush preset from the dropdown on the tool option bar (something that will load different settings.) Restart OpenToonz.

Expected Results

The brush tool should retain the brush settings that were loaded from the preset.

Actual Results

The brush tool settings revert to the last time the brush settings controls were manipulated on the tool option bar.

System Information

  • OpenToonz Version: Latest Nightly
  • Operating System: Windows
@RodneyBaker
Copy link
Collaborator

@melieconiek initial testing appears to show this working as designed.
If we want to transfer the preset to the default settings of the brush tool so that the settings will still be there when we reopen we have to use File > Project Management > Save Default Settings*
This can be given a shortcut such as Ctrl + Shift + D for easier access to locking down those presets as default settings.

*Note for those looking in: This is view the current menu organization in latest nightly releases.

Aside: I want to thank you for posting this because I haven't used brush presets in the past and I should be using them. I will be using them!

@melieconiek
Copy link
Contributor Author

You can change the global default simply by manipulating the controls, there's no need to keybind anything. Why would changing the settings via a preset selection be any different from changing them by moving a slider? The work around I had for this was moving something on the tool option bar to make sure it had saved the change I had made.

The expected behavior would be for all tools, not just the brush tool, to retain whatever settings were last used--the brush tool isn't doing this properly. I seriously doubt this is working as intended.

@RodneyBaker
Copy link
Collaborator

I agree that it should be an easy update/enhancement.
I'll tag as UX enhancement and leave it open for further testing and validation.
I can see cases where a user would not want the presets to update the defaults so I'm not sure how that would be dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants