Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard tags to Spans? #22

Closed
pkwarren opened this issue Nov 26, 2018 · 1 comment
Closed

Add standard tags to Spans? #22

pkwarren opened this issue Nov 26, 2018 · 1 comment

Comments

@pkwarren
Copy link
Contributor

There are some tags which seem like they'd be useful to expose out of the box with the default interceptors, including:

  • kind: client/server
  • component: grpc-java
  • grpc.status: Status.getCode().name()
  • error: true (if status.isOk() returns false)

What is your feeling on adding some of these tags to the Spans created by opentracing-grpc? Should this be provided for all consumers (for consistent instrumentation) or added by consumers using the span decorator interfaces?

@malafeev
Copy link
Contributor

I think standard tags should be added for all consumers.
#23 can also be fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants