-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In interceptor mode, TracingDriver#acceptsURL should accept URLs without "tracing:" #68
Comments
that's not so simple. this |
We could modify
I think this makes sense. Since in interceptor mode, the driver is supposed to be able to intercept JDBC operations without the need of modifying JDBC URLs, so it should not even try to find |
@yisheng-liang would you like to submit PR? |
Are you going to cut a new release soon? Releases were cut in January quite often but nothing in February. |
0.2.9 is released |
Interceptor mode may not work in some cases. For instance, if another wrapper driver calls
Driver#acceptsURL
for each registered driver in order to find an underlying driver, it won't seeTracingDriver
unless the JDBC URL has been rewritten to have thejdbc:tracing:
prefix.Simple fix is to change
TracingDriver#acceptsURL
to be:The text was updated successfully, but these errors were encountered: