Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements equals method #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implements equals method #97

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Sep 14, 2020

Fix #83

@quaff quaff mentioned this pull request Sep 14, 2020
Open
@coveralls
Copy link

coveralls commented Sep 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 311

  • 0 of 43 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.06%) to 48.236%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/TracingDataSource.java 0 7 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingCallableStatement.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingPreparedStatement.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingStatement.java 0 9 0.0%
Totals Coverage Status
Change from base Build 310: -2.06%
Covered Lines: 506
Relevant Lines: 1049
💛 - Coveralls

randallt
randallt reviewed Sep 14, 2020
View reviewed changes
Copy link

@randallt randallt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this doesn't use the trick mentioned in #83 to get through the WrapperProxy/Proxy objects, can you explain how this fixes the problem? Did you test with debugging output and ever get a 'true' result (where the WrapperProxy is used)?

@quaff
Copy link
Contributor Author

quaff commented Sep 15, 2020

As this doesn't use the trick mentioned in #83 to get through the WrapperProxy/Proxy objects, can you explain how this fixes the problem? Did you test with debugging output and ever get a 'true' result (where the WrapperProxy is used)?
No tested, you should provide a minimal test case.

@quaff
Copy link
Contributor Author

quaff commented Sep 15, 2020

@randallt WrapperProxy added, but I think It should be done by WrapperProxy self.

@quaff
Copy link
Contributor Author

quaff commented Sep 21, 2020

@randallt Could you provide a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randallt randallt randallt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leak using c3p0 pooling library
3 participants
@quaff @coveralls @randallt