Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pass custom tags to TracingKafkaUtils. buildAndInjectSpan #77

Open
zrashwani opened this issue Jul 3, 2020 · 4 comments
Open

Comments

@zrashwani
Copy link

Hello all,
I found that we cannot pass some custom tags via TracingKafkaUtils.buildAndInjectSpan method, which we usually need when using this library, so we end up writing our wrapper class with the needed method to add the tags.

Is there another way to pass custom tags to spans created with this class?
and in case you think it is a useful feature that can be added to the library, I intend to contribute by adding another variation of buildAndInjectSpan method with additionalTags parameter.

@malafeev
Copy link
Contributor

malafeev commented Jul 6, 2020

@zrashwani new method should have parameter Collection<SpanDecorator> spanDecorators. That's way to set additional tags.

@mysteryer
Copy link

@malafeev but I can't add a new spanDecorators in 'TracingKafkaProducer', because constructor function TracingKafkaProducer(producer,tracer, spanDecorators,producerSpanNameProvider) is default.

@mysteryer
Copy link

@malafeev how can I change the private member Collection<SpanDecorator> spanDecorators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants