Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to only propagate existing traces for more effective tracing rollouts #574

Open
william-tran opened this issue May 12, 2020 · 1 comment

Comments

@william-tran
Copy link

When rolling out specialagent to existing, complex architectures, I'm finding that there are many traces that don't correspond to the use cases that intend to be traced. To make a tracing rollout more deliberate and to better show the initial value of tracing, it would be great to have an option for specialagent to only continue existing traces and not start new ones. The grunt work in tracing that auto-instrumentation helps with is trace propagation, and we'd continue to benefit from that with this option enabled. This option could be rule-specific as well.

Before:

  1. Add specialagent to a set of services involved in a trace.
  2. Check your tracing backend. You see the operation you wanted to trace starting at the ingress service, among lots of other traces from all services that are essentially noise.

After:

  1. Add specialagent to a set of services involved in a trace.
  2. Check your tracing backend. You don't see any traces yet.
  3. In the ingress service, either a) use the opentracing API directly to create spans for each ingress operation, or b) set an option to allow only the spring-mvc rule to start new traces.
  4. Check your tracing backend. You now see traces that correspond to the ingress operations that you intended to trace. If you did 3a), these ingress operations are named exactly as you named them.
@william-tran
Copy link
Author

Alternatively, if using a Jaeger tracer, we could get the same thing by setting a default sampling strategy of probability 0, and having a whitelist of services + operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant