Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve concurrent rule #576

Open
redzippo1 opened this issue Jun 9, 2020 · 5 comments
Open

Improve concurrent rule #576

redzippo1 opened this issue Jun 9, 2020 · 5 comments

Comments

@redzippo1
Copy link

Hi :

Thank you for take this project to us.

Our team want to use concurrent rule in our project. But this rule is not profect yet (eg: it only support method "execute" of ThreadPoolExecutor in ExecutorAgentRule).
So if you like, we hope to finish the work together. We'll sort out the ideas and ask for your approval before we develop them.

Is this ok?

@malafeev
Copy link
Contributor

malafeev commented Jun 9, 2020

@redzippo1 PR is welcome

@redzippo1
Copy link
Author

redzippo1 commented Jun 11, 2020

@malafeev

Hi :

We had some discussions today.

We want to divide AgentRule by thread pool type, but not method in each ExecutorService (eg: a class named ThreadPoolExecutorAgentRule for ThreadPoolExecutor, and a class named ScheduledThreadPoolExecutorAgentRule for ScheduledThreadPoolExecutor).

How do you feel that ?

THX

@malafeev
Copy link
Contributor

@redzippo1 I'm not sure that I understand what you want to achieve. Primary goal of concurrent rule is to propagate active span into new thread. So if you have an active span and then create new thread then new thread also will have active span.

@redzippo1
Copy link
Author

@malafeev

I am agree what you said above.

What I try to say is : we want to merge FixedDelayAgentRule, FixedRateAgentRule, ScheduledCallableAgentRule, ScheduledRunnableAgentRule functions into one class named like ScheduledThreadPoolExecutorAgentRule, and extend ExecutorAgentRule for supporting more methods of ThreadPoolExecutor.

Am I right?

@malafeev
Copy link
Contributor

@redzippo1 sounds cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants