Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getRequestURL instead of getMethod for naming the spans #45

Closed
piyushkumar13 opened this issue Oct 26, 2018 · 2 comments
Closed

Use getRequestURL instead of getMethod for naming the spans #45

piyushkumar13 opened this issue Oct 26, 2018 · 2 comments

Comments

@piyushkumar13
Copy link

piyushkumar13 commented Oct 26, 2018

Giving name to spans based on the HTTP Method does not look intuitive on the tracers UI(Jaeger, Lightstep, Zipkin etc). For example there can be several PUT
requests and the span will look in the UI with name "PUT" in the tracer. A viewer cannot figure out that PUT request is related with which URL(or which service) until he click on the span and checks the tags.
Here is the view from Lightstep (Note : regdiscovery-tracer is the name of the tracer)
screen shot 2018-10-26 at 10 26 12 pm

I think it will good to use request URL instead of HTTP Method so that viewer at the first view on the tracer UI can figure out the particular span is meant for which http request.

@pavolloffay
Copy link
Collaborator

We cannot use URL as operation name due to high cardinality. For example requests for the same operation might have two different URLs e.g. wildcard mapping.

@piyushkumar13
Copy link
Author

@pavolloffay Agreed. But you can use combination of both HTTPMethod and RequestURL.
Ex - GET<space>http://localhost:9999/hello. It will be more distinguishing instead of just using HTTPMethod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants