Need for a lock when setting the global Tracer

[carlosalberto]

Hey @mikebryant

Currently we have a lock used when setting opentracing.Tracer (and also, indirectly, when creating a Tracer through the OPENTRACING_TRACER_CALLABLE value), and I'm wondering whether this is needed.

Before Django 1.10, the middleware is supposed to be initialized only once when the first request takes place (https://docs.djangoproject.com/en/1.9/topics/http/middleware/#init)

As of Django 1.10, the middleware will be initialized only once at server start (https://docs.djangoproject.com/en/1.10/topics/http/middleware/#init-get-response)

Is there any advanced need to take a lock? I remember you mentioning forking, but I have forgotten the details now ;)

[carlosalberto]

Hey @mikebryant

Any news on this? ;)

[carlosalberto]

Due to lack of answer, I will proceed to remove this lock - I haven't seen any need for this one (from the very Django perspective).

[mikebryant]

Sorry, I've been dropping the ball here. Please go ahead.

[carlosalberto]

Thanks Mike!

[naphthalene]

Can we get a release with this change published please?

[carlosalberto]

@naphthalene I'd say in 1 week - would like to verify the other framework instrumentations are in proper shape before we release it.

[carlosalberto]

Closing as this has been solved for long time ;)