Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy section into .travis.yml #41

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Sep 8, 2019

Hello @carlosalberto and @yurishkuro,

The main purpose of this PR is to simplify the deployment flow.
Please note that user and encrypted password must be set properly.

Useful links:

Best regards!

The main purpose of this commit is to simplify the deployment flow.
Note that user and encrypted password must be set properly.

Useful links:
 - docs.travis-ci.com/user/encryption-keys
 - docs.travis-ci.com/user/deployment/pypi
 - docs.travis-ci.com/user/deployment#examples-of-conditional-deployment
 - docs.travis-ci.com/user/conditional-builds-stages-jobs
 - docs.travis-ci.com/user/conditions-v1
@Jamim
Copy link
Contributor Author

Jamim commented Sep 13, 2019

Hello @yurishkuro,
Can you please take a look at this PR?
It's similar to uber-common/opentracing-python-instrumentation#94
Thank you!

@yurishkuro
Copy link

@Jamim I don't maintain this repo, nor do I have access to its pypi package, so I can't create the secrets.

cc @opentracing-contrib/ot-contrib-python-maintainers

@Jamim
Copy link
Contributor Author

Jamim commented Sep 16, 2019

Hello @carlosalberto,
Could you please take a look at this PR?
Thanks!

@Jamim Jamim mentioned this pull request Sep 17, 2019
@Jamim
Copy link
Contributor Author

Jamim commented Oct 10, 2019

ping @carlosalberto

@@ -13,12 +13,19 @@ python:
stages:
- lint
- test
- name: deploy
if: tag is present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this is done so a new tag will cause a deployment, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @carlosalberto,
Right. Any new tag pushed to GitHub will cause a deployment.


matrix:
include:
- stage: lint
name: flake8
python: '3.7'
- stage: deploy
name: Deploy to PyPI
python: '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need Python 3.7 for deploying? Just curious about why we don't use Python 2.7 ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that any Python version could be used for deploying.
At the same time, I believe that it makes sense to use a version which will be EOLed later than sooner, so Python 2.7 with end-of-life on 2020-01-01 is not a good option.

@carlosalberto carlosalberto merged commit 67bf70a into opentracing-contrib:master Oct 20, 2019
@Jamim Jamim deleted the feature/travis-ci-pypi-deployment branch October 20, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants