-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Station/industry nearby industry lists can become incorrect after BuildOilRig is called #12506
Comments
JGRennison
added a commit
to JGRennison/Upstream-OpenTTD
that referenced
this issue
Apr 17, 2024
JGRennison
added a commit
to JGRennison/OpenTTD-patches
that referenced
this issue
Apr 17, 2024
glx22
pushed a commit
that referenced
this issue
Apr 17, 2024
glx22
pushed a commit
to glx22/OpenTTD
that referenced
this issue
Apr 18, 2024
glx22
pushed a commit
to glx22/OpenTTD
that referenced
this issue
Apr 18, 2024
glx22
pushed a commit
that referenced
this issue
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version of OpenTTD
master
Expected result
Station/industry nearby industry lists always correct.
Actual result
Station/industry nearby industry lists can become incorrect after BuildOilRig is called, because an industry tile is changed to a station tile without recalculating the relevant industry tile/station catchment overlaps.
This also applies to industry GRFs which have water-based industries (which aren't "oil rigs").
This only applies when _settings_game.station.serve_neutral_industries is true (the default).
This isn't related to the 14.0 desync issues, but that reminded me to check the desync logs from other servers, which highlighted this issue.
#12505 needs to be applied to have this logged using
debuglevel desync=2
, because the station/industry nearby checks are not effective without this applied.Steps to reproduce
Build a station with a catchment which overlaps only the future station tile of an under-construction oil rig or equivalent industry, or use the savegame below.
Issue 12506 Ltd, 1990-01-26.sav.zip
The text was updated successfully, but these errors were encountered: