Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullDesignSize overflow for large dimension #46

Closed
YomGarcia opened this issue Jul 13, 2021 · 0 comments · Fixed by #47
Closed

fullDesignSize overflow for large dimension #46

YomGarcia opened this issue Jul 13, 2021 · 0 comments · Fixed by #47

Comments

@YomGarcia
Copy link
Contributor

It can happen fullDesignSize gets overflowed when dealing with a large dimension problem
I propose the following simple fix

void MorrisExperimentGrid::setJumpStep(const Indices & jumpStep)
   // Update the jump step and check that we still might generate N_ trajectories
   // Compute step & number of total possibilities
   // Depending on direction
-  UnsignedInteger fullDesignSize = 2;
+  Scalar fullDesignSize = 2.;
   for (UnsignedInteger k = 0; k < jumpStep.getSize(); ++k)
   {
     const UnsignedInteger one = 1;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant