-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentype.js can only draw black text. #623
Comments
My take on this is, maybe opentype.js shouldn't draw at all. Why duplicate API? Have opentype.js just make the path on the canvas an the caller can fill and stroke it. |
We could do it either way. |
For me, I replaced the native text component for fabric.js with opentype.js drawing command. I had to rewrite the drawing command in order to be able to apply stroke and fill (and other effects, if I wanted) on it, since this isn't native to fabric.js, yet. I could convert them to paths, but I wanted the ability to to edit text and fonts. My fix is not perfect, but it pretty dang close to getting accurate bounding boxes on the text with a given font. |
Expected Behavior
There should be a way to specify the color of the text being drawn.
Current Behavior
opentype.js is the Henry Ford of font rendering "Any [user] can have [their text] any color that [they want] so long as it is black."
Possible Solution
Allow a color to be selected in the draw call for Font and Glyph objects.
Context
My library has to manually draw the path to work around this, granted I have to do this anyways as I need to stroke the text too, but my point stands.
The text was updated successfully, but these errors were encountered: