Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox search attribute and its values #931

Open
sudheer-gowrigari opened this issue Nov 4, 2023 · 2 comments
Open

Combobox search attribute and its values #931

sudheer-gowrigari opened this issue Nov 4, 2023 · 2 comments

Comments

@sudheer-gowrigari
Copy link
Collaborator

This issue aims to gather feedback on the naming and functionality of the search attribute on combobox element and its associated values (pattern, startswith, includes).

Copy link

github-actions bot commented May 6, 2024

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label May 6, 2024
@TheOneTheOnlyJJ
Copy link

A feature that should be considered is highlighting the matching text pattern, like illustrated with Material UI:

https://mui.com/material-ui/react-autocomplete/#highlights

The easiest way to achieve this would be through rendering a <strong> element around the matching text pattern.

This would eliminate the need for a 3rd party dependency (or just additional JS code) in many cases, as highlighting the matching pattern is a commonly desired functionality, especially in the case of includes. Having this implemented at the platform level in browsers would surely boost performance considerably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants