Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vclient <ip:port> not accepted anymore #58

Closed
fb22 opened this issue Jan 6, 2020 · 2 comments
Closed

vclient <ip:port> not accepted anymore #58

fb22 opened this issue Jan 6, 2020 · 2 comments

Comments

@fb22
Copy link

fb22 commented Jan 6, 2020

Since version 0.98.8:

$ vclient -h 127.0.0.1:3002 -c getSystemTime -v
Host: 127.0.0.1:3002 Port: 3002
[2308] Mon Jan 6 22:51:16 2020 : Error in getaddrinfo: 127.0.0.1:3002:Name or service not known

Possibly this issue is introduced with commit #52.
No issue when omitting port in host ip or using -h 127.0.0.1 -p 3002.

@hmueller01
Copy link
Collaborator

I just checked the code. ip:port is only evaluated if port is 0. @leifnel , #52 sets the default port to 3002, so this code gets ignored. I think we should always check for ip:port and throw an error if ip:port and -p is specified. Comments?

@speters
Copy link
Member

speters commented Jan 7, 2020

Pushed fix to v0.98.9

@speters speters closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants