Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted file sizes are suspiciously small #7

Closed
waldoj opened this issue May 3, 2014 · 2 comments
Closed

Converted file sizes are suspiciously small #7

waldoj opened this issue May 3, 2014 · 2 comments
Labels

Comments

@waldoj
Copy link
Member

waldoj commented May 3, 2014

2_corporate.txt is 227.6 MB. 2_corporate.csv is 11.5 MB. 5_officers.txt is 62.5 MB. 5_officers.csv is 882 KB. Unless I've accidentally implemented a brilliant compression algorithm, something is going missing.

@waldoj waldoj added the bug label May 3, 2014
@waldoj
Copy link
Member Author

waldoj commented May 3, 2014

$ wc -l 2_*
   33319 2_corporate.csv
  337131 2_corporate.txt

$ wc -l 5_*
   21849 5_officers.csv
  651421 5_officers.txt

Ah, yes—hundreds of thousands of records are going missing. That's probably the source of the problem. Not in all files, though—just some. Which is actually worse. :-/

@waldoj
Copy link
Member Author

waldoj commented May 3, 2014

Thanks to @brianjgeiger's refactor (per #15), no records are going missing anymore, based on a comparison of the new numbers to the above numbers. (We're no longer emitting the constituent fixed-width files to facilitate a direct comparison.)

@waldoj waldoj closed this as completed May 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant