Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added throttling policy for unauthenticated users #1531

Merged
merged 4 commits into from Jun 1, 2020

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented May 13, 2020

Added throttling policy for unauthenticated users.

Motivation and context

It's a good practice to have throttling policy for REST API to reduce security risks.

How has this been tested?

Manually

Checklist

  • I submit my changes into the develop branch
  • I have added description of my changes into CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (read github docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro azhavoro requested a review from nmanovic as a code owner May 13, 2020 13:46
@azhavoro azhavoro marked this pull request as draft May 15, 2020 20:35
@nmanovic
Copy link
Contributor

@azhavoro , any problems with the patch?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 65.657%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/project.py 1 77.49%
Totals Coverage Status
Change from base Build 5360: -0.009%
Covered Lines: 10837
Relevant Lines: 16101

💛 - Coveralls

@azhavoro azhavoro changed the title [WIP] Added throttling policy for unauthenticated users Added throttling policy for unauthenticated users May 29, 2020
@azhavoro azhavoro marked this pull request as ready for review May 29, 2020 11:52
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 4477e17 into develop Jun 1, 2020
@nmanovic nmanovic deleted the az/add_throttling_policy branch June 1, 2020 17:19
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
* added throttling policy for unauthenticated users

* updated changelog

Co-authored-by: Nikita Manovich <40690625+nmanovic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants