Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media extractors #2154

Merged
merged 9 commits into from Oct 1, 2020
Merged

Update media extractors #2154

merged 9 commits into from Oct 1, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Sep 8, 2020

Motivation and context

Follow up for #2141

  • Added PDF import tests
  • Fixed Loading PDF. RAM consumption.  #940
  • Fixed a problem with pdf cached chunks - after the first interpreter exit, extracted files were removed, making it impossible to recreate chunks
  • Refactored some code

zip - need to test if extracting is really necessary

How has this been tested?

Unit tests, manual tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max changed the title Update media extractors [WIP] Update media extractors Sep 8, 2020
@zhiltsov-max zhiltsov-max changed the title [WIP] Update media extractors Update media extractors Sep 9, 2020
@coveralls
Copy link

coveralls commented Sep 9, 2020

Coverage Status

Coverage increased (+0.1%) to 65.505% when pulling b72fd19 on zm/update-extractors into c2b17a0 on develop.

@nmanovic
Copy link
Contributor

@zhiltsov-max , could you please help to fix merge conflicts?

@nmanovic
Copy link
Contributor

@Marishka17 , could you please review and test the PR?

Marishka17
Marishka17 previously approved these changes Sep 14, 2020
cvat/apps/engine/media_extractors.py Outdated Show resolved Hide resolved
@zhiltsov-max zhiltsov-max changed the title Update media extractors [WIP] Update media extractors Sep 15, 2020
@zhiltsov-max zhiltsov-max changed the title [WIP] Update media extractors Update media extractors Sep 15, 2020
@bsekachev
Copy link
Member

@zhiltsov-max @Marishka17 @azhavoro What is status of this PR? Can me merge it?

@bsekachev bsekachev merged commit e9552f8 into develop Oct 1, 2020
@nmanovic nmanovic deleted the zm/update-extractors branch October 5, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading PDF. RAM consumption.
6 participants