Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: cannot read property 'label' of undefined #2311

Merged
merged 4 commits into from Oct 13, 2020
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 12, 2020

Motivation and context

I am not sure, but I hope the PR fixes issue #1823
I was not able to reproduce it, but watching an additional output, it seems to be that it might be 3rdparty issue.

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Oct 12, 2020
@bsekachev
Copy link
Member Author

@vnishukov

It isn't really great when I write a couple of lines to fix a bug and precommit adds a lot of changes.
It is getting difficult to review the PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.695% when pulling 654dc4a on bs/fixed_label_bug into df6e6fd on develop.

@ActiveChooN
Copy link
Contributor

@vnishukov

It isn't really great when I write a couple of lines to fix a bug and precommit adds a lot of changes.
It is getting difficult to review the PR.

Guess it's really strange, for example in our previous linting config we have 4 functional parameters in line restriction as i remember.

@bsekachev bsekachev merged commit bcc8bba into develop Oct 13, 2020
@bsekachev bsekachev deleted the bs/fixed_label_bug branch October 13, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants