Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: wrong attribute is removed in label constructor #2436

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 16, 2020

Motivation and context

Resolved #2411

How has this been tested?

Manual testing
@dvkruchinin Please, write a test for the issue
Scenario is:

  1. Open the create task page
  2. Go to Raw labels editor
  3. Insert there:
[
  {
    "name": "person",
    "color": "#ff6037",
    "attributes": [
      {
        "name": "lower_body",
        "input_type": "select",
        "mutable": true,
        "values": [
          "__undefined__",
          "long",
          "short",
          "n/a"
        ]
      },
      {
        "name": "hair_color",
        "input_type": "select",
        "mutable": true,
        "values": [
          "__undefined__",
          "black",
          "brown",
          "blond",
          "grey",
          "other",
          "n/a"
        ]
      },
      {
        "name": "cellphone",
        "input_type": "select",
        "mutable": true,
        "values": [
          "__undefined__",
          "yes",
          "no",
          "n/a"
        ]
      }
    ]
  }
]
  1. Press done
  2. Go to constructor tab, be sure that the label "person" appeared there
  3. Start editing it
  4. Try to remove the average attribute "hair_color", be sure it has been deleted
  5. Try to remove the latest attribute "lower_body", be sure it has been deleted

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Nov 16, 2020
@bsekachev bsekachev added this to In progress in UI via automation Nov 16, 2020
@dvkruchinin
Copy link
Contributor

Hi. Yes, of course. I will write a test to test this fix.

@coveralls
Copy link

coveralls commented Nov 16, 2020

Coverage Status

Coverage remained the same at 62.831% when pulling 546e30b on bs/fixed_issue_2411 into a9b2817 on develop.

ActiveChooN
ActiveChooN previously approved these changes Nov 16, 2020
UI automation moved this from In progress to Review in progress Nov 17, 2020
@bsekachev bsekachev merged commit 6bd68b8 into develop Nov 17, 2020
UI automation moved this from Review in progress to Done Nov 17, 2020
@bsekachev bsekachev deleted the bs/fixed_issue_2411 branch November 17, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
UI
  
Done
Development

Successfully merging this pull request may close these issues.

A bug with deleting attributes
4 participants