Update to Django 3.1.12. #3378
Merged
Update to Django 3.1.12. #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Jun 30, 2021
| @@ -275,7 +275,7 @@ def get_available_name(self, name, max_length=None): | |||
| return name | |||
|
|
|||
| def upload_path_handler(instance, filename): | |||
| return os.path.join(instance.data.get_upload_dirname(), filename) | |||
| return os.path.join(os.path.relpath(instance.data.get_upload_dirname(), settings.BASE_DIR), filename) | |||
There was a problem hiding this comment.
@MashaSS , Please add a comment why we have to do the change.
There was a problem hiding this comment.
Added a comment to function and a line to CHANGELOG.md.
|
@MashaSS , please add a line into CHANGELOG.md |
nmanovic
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
There is one commit in Django 3.1.11 which change the logic of file name validation (django/django@b7d4a6f). Before this commit it checked file name and transformed it by CVAT function to full upload path. After commit at first CVAT function give absolute path then Django check obtained path and failed with error SuspiciousFileOperation because it is the absolute path.
It leads to failures with response code 400 while trying to create a new task.
It is needed to change function
upload_path_handlerincvat/cvat/apps/engine/models.pyand don’t use absolute paths to avoid this error.How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.