Add note about redis server in wsl #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvkruchinin Hi, could you please take a look at these issues:
|
|
@StellaASchlotter, hi, thanks for the contribution. Personally, I start redis inside a docker for WSL without the necessity to start service manually. So, can you add a note about this case? |
nmanovic
previously approved these changes
Oct 28, 2021
nmanovic
reviewed
Oct 29, 2021
| @@ -110,3 +110,4 @@ You develop CVAT under WSL (Windows subsystem for Linux) following next steps. | |||
| ``` | |||
|
|
|||
| - Run all commands from this installation guide in WSL Ubuntu shell. | |||
| - You might have to manually start the redis server in wsl before you can start the configuration inside Visual Studio Code. You can do this with `sudo service redis-server start` | |||
There was a problem hiding this comment.
It is a very long line. Markdown linter complains about that: https://github.com/openvinotoolkit/cvat/actions/runs/1387241296 (see artifacts on the page)
|
@StellaASchlotter , will you have time to improve the PR a little bit? |
I will do it tomorrow. |
StellaASchlotter
force-pushed
the
fix/wsl_dev_env
branch
from
57da03e
to
9fbb190
Compare
|
I hope I addressed all remarks. Let me know if I should change anything. |
StellaASchlotter
force-pushed
the
fix/wsl_dev_env
branch
from
9fbb190
to
eac67d9
Compare
… usually not available per default.
StellaASchlotter
force-pushed
the
fix/wsl_dev_env
branch
from
eac67d9
to
d8c65d5
Compare
nmanovic
approved these changes
Nov 5, 2021
|
@StellaASchlotter , great job! Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a note about manually starting the redis server inside wsl. This is necessary because installing the redis-server package does not start it when systemd is not available.
Motivation and context
Multiple people ran into this problem and reported it on gitter. Also it's not obvious that you have to start it manually.
How has this been tested?
Manually
Checklist
developbranch- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.