Fixed possible color collisions in the generated colormap #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dvkruchinin <dvkruchinin@gmail.com>
nmanovic
reviewed
Dec 10, 2021
added 3 commits
December 10, 2021 13:31
nmanovic
reviewed
Dec 10, 2021
nmanovic
reviewed
Dec 10, 2021
Comment on lines
72
to
75
| sorted_colors = sorted(used_colors) | ||
| max_dist = max(zip(sorted_colors, sorted_colors[1:]), key=lambda c_pair: c_pair[1][0] - c_pair[0][0]) | ||
|
|
||
| return ((max_dist[0][0] + max_dist[1][0]) // 2, max_dist[0][1], max_dist[0][2]) |
There was a problem hiding this comment.
Hi, @azhavoro, Is it the final version of this patch? If it is, then I have a question:
Will this solution work correctly if all used colors have a same R-value? For example in case:
used_colors = [(100, 0, 0), (100, 50, 0), (100, 0, 50)]
this code will return (100, 0, 0) but this color is already use. I'm not sure that such situation is very likely, but it seems to me that we can extend this algorithm to other components of the color as well.
ActiveChooN
reviewed
Dec 13, 2021
| if color is None: | ||
| color = get_color_from_index(DEFAULT_COLORMAP_CAPACITY + offset) |
There was a problem hiding this comment.
this const is not used, so should be deleted
|
@dvkruchinin Hi, could you prepare a test for this case? |
Hi, sure. A test will be prepared. |
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.