Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature parity #22

Closed
JarbasAl opened this issue May 22, 2023 · 2 comments
Closed

feature parity #22

JarbasAl opened this issue May 22, 2023 · 2 comments
Assignees
@JarbasAl @NeonDaniel
Labels
bug Something isn't working

Comments

@JarbasAl
Copy link
Member

the mic level meter is not implemented here, use https://github.com/NeonGeckoCom/neon-audio-plugin-noise instead

config auto reload is not implemented https://github.com/OpenVoiceOS/ovos-config/blob/dev/ovos_config/config.py#L258
@JarbasAl JarbasAl added the bug Something isn't working label May 22, 2023
NeonDaniel added a commit that referenced this issue May 23, 2023
@NeonDaniel
Add Configuration change callback handler
8f7eaef 
#22
@NeonDaniel NeonDaniel mentioned this issue May 23, 2023
Merged
@NeonDaniel
Copy link
Member

Is mic level used anywhere? I forgot about it since deprecating the signal directory in Neon.

Unless its necessary, I'd rather not implement it here and leave it to a CLI to integrate with the noise plugin directly

@JarbasAl
Copy link
Member Author

only used by the cli i think, users that want it should install the companion Neon plugin (updates might be needed, i did not test it)

@github-actions github-actions bot mentioned this issue Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JarbasAl JarbasAl

@NeonDaniel NeonDaniel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JarbasAl @NeonDaniel