Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifconfig_broadcast environment variable is empty since 2.5 #527

Closed
lfarkas opened this issue Mar 21, 2024 · 4 comments
Closed

ifconfig_broadcast environment variable is empty since 2.5 #527

lfarkas opened this issue Mar 21, 2024 · 4 comments
Assignees
Labels
documentation documentation only, no code affected patch-submitted There is a patch on the list waiting for merge

Comments

@lfarkas
Copy link

lfarkas commented Mar 21, 2024

in 2.4.x the $ifconfig_broadcast containers the last/broadcast address of the vpn network. since 2.5 it's empty in the auth-user-pass-verify cmd en vase of via-env

@flichtenheld
Copy link
Member

Yes, this is correct. This was removed in 2.5.0. See commit 6c8b33f. The only place it is still mentioned is the documentation. We definitely should remove it there as well.

@flichtenheld flichtenheld self-assigned this Mar 21, 2024
@flichtenheld flichtenheld added documentation documentation only, no code affected patch-submitted There is a patch on the list waiting for merge labels Mar 21, 2024
@lfarkas
Copy link
Author

lfarkas commented Mar 22, 2024

and at least in the release notes as the breaking changes since many scripts can use it...

@cron2
Copy link
Contributor

cron2 commented Mar 22, 2024

and at least in the release notes as the breaking changes since many scripts can use it...

2.5.0 was released in October 2020, so close to 3.5 years ago... and you're the first one to notice. So it's not really "many scripts".

Changing the release notes for 2.5.0 is slightly complicated, as our time machine is on repair :-) - but I agree we could be better in pointing out user-visible changes. We normally try to point out such changes, but it seems this was overlooked as the commit itself does not really concern itself with environment variables, but with removing code for ifconfig etc that never served a real purpose.

@lfarkas
Copy link
Author

lfarkas commented Mar 22, 2024

rhel/centos/alma/rocky 6,7,8 only contains 2.4 while 9 is 2.5 so everybody upgrade there os will find it now. and only in case of server upgrade not client...

cron2 pushed a commit that referenced this issue Mar 26, 2024
- Remove obsolete ifconfig_broadcast. Since this was
  removed in 2.5.0, do not add a removal note but just
  completely remove it.
- Add missing documentation of IPv6 variants for
  ifconfig_pool_* variables.

Github: fixes #527
Change-Id: Ia8c8de6799f0291fc900628fbd06c8a414e741ca
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20240321161623.2794161-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28438.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit a94226c)
@cron2 cron2 closed this as completed in a94226c Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation only, no code affected patch-submitted There is a patch on the list waiting for merge
Projects
None yet
Development

No branches or pull requests

3 participants