Make sdjwt instance non abstract #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
requested review from
lukasjhan,
zustkeeper and
berendsliedrecht
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #122 +/- ##
==========================================
+ Coverage 96.05% 97.18% +1.12%
==========================================
Files 22 23 +1
Lines 1826 1844 +18
Branches 259 264 +5
==========================================
+ Hits 1754 1792 +38
+ Misses 72 52 -20 ☔ View full report in Codecov by Sentry. |
lukasjhan
reviewed
Feb 28, 2024
Comment on lines
+35
to
+36
| The library can be used to create sd-jwt based credentials. To be compliant with the `sd-jwt-vc` standard, you can use the `@sd-jwt/sd-jwt-vc` that is implementing this spec. | ||
| If you want to use the pure sd-jwt class or implement your own sd-jwt credential approach, you can use this library. |
There was a problem hiding this comment.
Good. I'll change the package name in #118
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
added a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
added a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #114 the sdjwtinstance should be non abstract to allow people to use it on its own.
I included the
validateReservedFieldsfunction that will return nothing in the sdjwtinstance, but can be implemented in extended classes likesdjwtvcinstance. Doing so, we don't have to override the while isse functionSigned-off-by: Mirko Mollik mirko.mollik@fit.fraunhofer.de