feat: create kb jwt when present all #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
lukasjhan
requested review from
zustkeeper,
berendsliedrecht and
cre8
as code owners
lukasjhan
commented
Mar 3, 2024
| @@ -146,17 +146,19 @@ export class SDJwtInstance<ExtendedPayload extends SdJwtPayload> { | |||
| kb?: KBOptions; | |||
| }, | |||
| ): Promise<SDJWTCompact> { | |||
| if (!presentationKeys) return encodedSDJwt; | |||
There was a problem hiding this comment.
Due to the early return, kbjwt is not created.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #129 +/- ##
=======================================
Coverage 97.38% 97.39%
=======================================
Files 23 23
Lines 1876 1878 +2
Branches 272 272
=======================================
+ Hits 1827 1829 +2
Misses 49 49 ☔ View full report in Codecov by Sentry. |
|
Good point, since the key binding has nothing to do with the selective disclosure, but with the holder binding. |
cre8
approved these changes
Mar 3, 2024
cre8
pushed a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In present method, when
presentationKeysis undefined, then present all disclosures. but in this case kbjwt is not created.I fixed it to create kbjwt.