Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make _digest value public in disclosure #151

Merged

Conversation

lukasjhan
Copy link
Member

I made _digest value in disclosure as public.

When implementing features in holder side, usually we decode the disclosures and make a logic. In this situation we normally have _digest value, not need to calculate. So delivering hasher to get _digest value is not necessary.

It closes #150

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (612bf82) to head (19445b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #151   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          23       23           
  Lines        1983     1991    +8     
  Branches      284      284           
=======================================
+ Hits         1938     1946    +8     
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasjhan
Copy link
Member Author

Hmm.. It's strange. biome success in local env

@cre8
Copy link
Contributor

cre8 commented Mar 9, 2024

Hmm.. It's strange. biome success in local env

Same for me. Running biome ci . or pnpm run format or lint locally is fine....
There is also no update for the biome action in the cicd that could cause that

cre8 added 2 commits March 9, 2024 23:54
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@cre8
Copy link
Contributor

cre8 commented Mar 9, 2024

@lukasjhan found the error:
Biome release a new minor update, that added more rules. Locally, we are using version 1.5.0, but when we used the github action, it is always going for latest, in our case 1.6.0. So there were some new rules that causes the issue. I applied the changes, tests are passing.

Changes were applied via biome directly and not manually. Since all tests passed it should be fine

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@cre8
Copy link
Contributor

cre8 commented Mar 9, 2024

I referenced the biome call to the package json to make sure we got the same versions and therefore the same behavior local and in the ci.

@lukasjhan
Copy link
Member Author

@cre8 Thank you :)

@lukasjhan lukasjhan merged commit 9baa93e into openwallet-foundation-labs:next Mar 9, 2024
10 checks passed
cre8 added a commit to cre8/sd-jwt-js that referenced this pull request Mar 11, 2024
…labs#151)

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8 added a commit to cre8/sd-jwt-js that referenced this pull request Mar 11, 2024
…labs#151)

Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disclosure digest should be accessible without providing Hasher
2 participants