fix: add public param #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
requested review from
lukasjhan,
zustkeeper and
berendsliedrecht
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 21 21
Lines 1514 1514
Branches 229 229
=======================================
Hits 1394 1394
Misses 113 113
Partials 7 7 ☔ View full report in Codecov by Sentry. |
lukasjhan
approved these changes
Feb 23, 2024
cre8
added a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de> Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8
added a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de> Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
--no-privateflag since npmjs default setting is private