Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Lissi OOB URLs #1581

Closed
genaris opened this issue Sep 22, 2023 · 1 comment · Fixed by #1583
Closed

Incompatibility with Lissi OOB URLs #1581

genaris opened this issue Sep 22, 2023 · 1 comment · Fixed by #1583

Comments

@genaris
Copy link
Contributor

genaris commented Sep 22, 2023

I've recently trying out Lissi demo to see how far an AFJ-based app can go and I noticed that in their invitation URLs they are using oob query parameter and encoding a connections/1.0/invitation message into it. AFJ expects it to be an out-of-band/1.x/invitation message, so as a result it throws a validation error when scanning the code.

Whilst I think AFJ interpretation is correct, based on the wording from Aries RFC 0434 where it says The oob query parameter is required and is reserved to contain the out-of-band message string one could also interpret that 'out-of-band' refers to any DIDComm message that will be send out of band (i.e not strictly from the out-of-band protocol).

So in some way I don't see that it would be harmful to allow processing a former connections protocol invitation encoded in oob query parameter. What do you think?

@TimoGlastra
Copy link
Contributor

Yeah makes sense! No harm in supporting it I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants