Import error on iOS

[CarolineLCa]

Hello,

I'm testing import function but I noticed that when we put the wrong backup password all the wallet stops working.

The import function calls react-native-fs copyFile, but for iOS the copyFile function returns an error when the destination file already exists as mentioned in their Readme.

[WalletError: Error importing wallet 'walletId': “walletName.awlt” couldn’t be copied to “walletId” because an item with the same name already exists.]

Thanks!

[TimoGlastra]

Thanks for opening the issue @CarolineLCa.

Copying a wallet to a destination that already exists should fail, but maybe we need to improve the error handling for this.

Do you have an expected outcome of how this should work?

[CarolineLCa]

Hi @TimoGlastra

I have tested the import function on Android and the file is overwritten by the new file being imported. The import function does this action using the copyFile method.

But on iOS it returns that error because copyFile can’t overwrite files there.

So, I was expecting that iOS would work the same way as Android.

[genaris]

Discussed in today's AFJ WG call. For that case it should throw an error in all platforms.

We have also to make sure that if a wrong password is submitted, no wallet files are created.