Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DidDocumentOptions.controller field has a wrong type #1643

Closed
spivachuk opened this issue Nov 21, 2023 · 1 comment · Fixed by #1644
Closed

DidDocumentOptions.controller field has a wrong type #1643

spivachuk opened this issue Nov 21, 2023 · 1 comment · Fixed by #1644

Comments

@spivachuk
Copy link

The type of DidDocumentOptions.controller field does not permit a string value which is a correct one for DidDocument.controller field:

interface DidDocumentOptions {
  ...
  controller?: string[]
  ...
}

export class DidDocument {
  ...

  @IsStringOrStringArray()
  @IsOptional()
  public controller?: string | string[]
  
  ...
}
@berendsliedrecht
Copy link
Contributor

Thanks for pointing it out. #1644 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants