Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof request attribute value restrictions should only be allowed for values that are exposed #1690

Open
TimoGlastra opened this issue Jan 7, 2024 · 0 comments

Comments

@TimoGlastra
Copy link
Contributor

TimoGlastra commented Jan 7, 2024

It should not be possible to use query restrictions in an anoncreds proof request without revealing those attributes.

I.e. A proof request with attr::age::value should not be allowed if there's no requested attribute with that. Markers should be allowed maybe, as they're less revealing. But they have become basically obsolete with credentials not supporting optionality anymore (hyperledger/anoncreds-rs#290).

This has a security impact as you can filter credentials without the values being exposed. It doesn't give you a guarantee but can result in knowing what other fields are in the credential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant