Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RFC 0035: Problem Report #58

Closed
jakubkoci opened this issue Jul 3, 2020 · 4 comments · Fixed by #560
Closed

Add support for RFC 0035: Problem Report #58

jakubkoci opened this issue Jul 3, 2020 · 4 comments · Fixed by #560
Assignees
@nbAmit
Labels
AIP 1.0 Tasks related to AIP 1.0 support Protocol Tasks related to an Aries Protocol Type: Enhancement

Comments

@jakubkoci
Copy link
Contributor

jakubkoci commented Jul 3, 2020 •
edited by TimoGlastra
Loading

It would be also nice to define some structure or rules for error handling answering questions:

  • When and where we want to throw/handle errors?
  • Problem report adopted into other protocols
  • initiating problem report as standalone protocol
@TimoGlastra TimoGlastra added this to the 0.1 milestone Jul 17, 2020
@TimoGlastra TimoGlastra mentioned this issue Jul 17, 2020
Closed
3 tasks
@jakubkoci jakubkoci mentioned this issue Jul 24, 2020
Closed
@TimoGlastra TimoGlastra added the AIP 1.0 Tasks related to AIP 1.0 support label Jul 3, 2021
@TimoGlastra TimoGlastra changed the title Add Problem Report protocol Add support for RFC 0035: Problem Report Jul 3, 2021
@TimoGlastra TimoGlastra added the Protocol Tasks related to an Aries Protocol label Jul 3, 2021
@TimoGlastra TimoGlastra modified the milestones: 0.1, AIP 1.0 Jul 3, 2021
@nbAmit
Copy link
Contributor

nbAmit commented Nov 8, 2021

@jakubkoci @TimoGlastra I Would like to work on this

@TimoGlastra
Copy link
Contributor

Awesome!

@nbAmit nbAmit mentioned this issue Dec 2, 2021
Merged
@TimoGlastra TimoGlastra linked a pull request Dec 8, 2021 that will close this issue
feat: add problem report protocol #560
Merged
@jakubkoci
Copy link
Contributor Author

Shouldn't we reopen this issue? I think we have still a few things we should address before closing.

@TimoGlastra
Copy link
Contributor

I think it would be better to open specific issues for the outstanding tasks.

Are you mainly talking about the outstanding tasks from the PR or the tasks form the list in this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbAmit nbAmit

Labels
AIP 1.0 Tasks related to AIP 1.0 support Protocol Tasks related to an Aries Protocol Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add problem report protocol nbAmit/aries-framework-javascript
3 participants
@jakubkoci @TimoGlastra @nbAmit