Feature: introduce CSRF protection #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec
force-pushed
the
feature/csrf_protec
branch
2 times, most recently
from
e29b72c
to
7618cf2
Compare
alinetskyi
suggested changes
Dec 27, 2019
ysv
suggested changes
Dec 27, 2019
There was a problem hiding this comment.
- I advice we take a look into default ActionController implementation of CSRF
ActionController::RequestForgeryProtectionand either we use it or follow the same principle - https://medium.com/rubyinside/a-deep-dive-into-csrf-protection-in-rails-19fa0a42c0ef
ec
force-pushed
the
feature/csrf_protec
branch
from
7618cf2
to
fbf7d8d
Compare
ec
force-pushed
the
feature/csrf_protec
branch
from
fbf7d8d
to
1beed69
Compare
ysv
approved these changes
Jan 8, 2020
mod
requested changes
Jan 9, 2020
ec
force-pushed
the
feature/csrf_protec
branch
from
1beed69
to
a225ef2
Compare
mod
reviewed
Jan 15, 2020
mod
reviewed
Jan 15, 2020
mod
requested changes
Jan 15, 2020
chumaknadya
force-pushed
the
feature/csrf_protec
branch
from
a225ef2
to
db7f2d7
Compare
chumaknadya
force-pushed
the
feature/csrf_protec
branch
from
db7f2d7
to
ca75850
Compare
mod
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple and effective CSRF protection overview and protection principles https://www.linkedin.com/pulse/how-protect-your-app-from-csrf-artem-linetskyi by @alinetskyi