Add errors.md #2080
Merged
Add errors.md #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaichuk
force-pushed
the
feature/new-errors-errorsmd
branch
2 times, most recently
from
b6c77a7
to
fbbefd8
Compare
ysv
suggested changes
Feb 18, 2019
docs/api/errors.md
Outdated
| account.deposit.invalid_state Deposit invalid state | ||
| account.deposit.non_integer_limit Value you send could not be parsed into Integer type | ||
| account.deposit.invalid_limit Invalid limit | ||
| account.deposit.non_integer_limit Limit value you send could not be parsed into Integer type |
docs/api/errors.md
Outdated
| account.deposit_address.invalid_address_format Invalid deposit address format | ||
| account.deposit_address.doesnt_support_cash_address_format Currency doesn't support cash address format | ||
| account.currency.doesnt_exist Currency doesn't exist | ||
| account.withdraw.non_integer_limit Limit Value you send could not be parsed into Integer type |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
docs/api/errors.md
Outdated
| account.withdraw.invalid_amount Invalid withdraw amount | ||
| account.withdraw.create_error Failed to create withdraw | ||
| account.withdraw.invalid_otp Invalid otp | ||
| withdraw.status.disabled Withdrawal API is disabled |
mnaichuk
force-pushed
the
feature/new-errors-errorsmd
branch
2 times, most recently
from
f137cdb
to
b24fc3b
Compare
mnaichuk
force-pushed
the
feature/new-errors-errorsmd
branch
from
b24fc3b
to
9628d38
Compare
shal
force-pushed
the
feature/new-errors-errorsmd
branch
from
33f7708
to
7f82ee9
Compare
ysv
pushed a commit
that referenced
this pull request
Feb 20, 2019
* Add errors.md, code polishing * Updates some errors desc * Update spec * Make errors human readable & Pretiffy markdown * Update errors.md desc
ysv
pushed a commit
that referenced
this pull request
Feb 20, 2019
ysv
pushed a commit
that referenced
this pull request
Feb 20, 2019
- Move all REST API errors to single structure `{errors: []}`
- Detailed description for order & withdraw POST failures
- Add missing values validations
- Add missing allow_blank validations
- Add custom errors message for:
- values validations
- types validations
- allow_blank validations
- presence validations
- custom validations
- Add errors.md with errors list & description
- Remove DB queries from desc
- Remove API::V2::Error and descendants
- Update ExceptionHandlers
- Move NamedParams to /market
- Add Order::InsufficientMarketLiquidity
- include_api_error rspec matcher
Co-authored-by: Yaroslav Savchuk <ysavchuk@heliostech.fr>
Co-authored-by: Maksim Naichuk <mnaichuk@heliostech.fr>
Co-authored-by: Ali Shanaakh <ashanaakh@heliostech.fr>
mod
pushed a commit
that referenced
this pull request
Feb 20, 2019
* Unify API errors for api/v2/market/* (#2058) * Unify API errors for api/v2/account/* and api/v2/public/* (#2063) * Add errors.md with list of Member API errors (#2080) - Move all REST API errors to single structure `{errors: []}` - Detailed description for order & withdraw POST failures - Add missing values validations - Add missing allow_blank validations - Add custom errors message for: - values validations - types validations - allow_blank validations - presence validations - custom validations - Add errors.md with errors list & description - Remove DB queries from desc - Remove API::V2::Error and descendants - Update ExceptionHandlers - Move NamedParams to /market - Add Order::InsufficientMarketLiquidity - include_api_error rspec matcher Co-authored-by: Yaroslav Savchuk <ysavchuk@heliostech.fr> Co-authored-by: Maksim Naichuk <mnaichuk@heliostech.fr> Co-authored-by: Ali Shanaakh <ashanaakh@heliostech.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.