Remove deprecated amqp daemons #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
from
4c80364
to
8976313
Compare
mod
reviewed
Feb 17, 2020
app/models/order.rb
Outdated
| @@ -154,11 +154,29 @@ def funds_used | |||
| origin_locked - locked | |||
| end | |||
|
|
|||
| def trigger_pusher_event | |||
| def ws_notify | |||
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
4 times, most recently
from
6fd06a6
to
c78c268
Compare
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
from
c78c268
to
350fc4f
Compare
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
3 times, most recently
from
ef494d8
to
55b1d49
Compare
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
2 times, most recently
from
0746322
to
384a7da
Compare
mod
reviewed
Feb 18, 2020
| end | ||
|
|
||
| ActiveSupport.on_load(:active_record) { ActiveRecord::Base.include EventAPI::ActiveRecord::Extension } | ||
| require 'amqp/event_api' |
There was a problem hiding this comment.
after require put the line:
ActiveSupport.on_load(:active_record) { ActiveRecord::Base.include EventAPI::ActiveRecord::Extension }
mod
requested changes
Feb 18, 2020
app/models/order.rb
Outdated
| @@ -19,7 +19,7 @@ class Order < ApplicationRecord | |||
|
|
|||
| belongs_to :ask_currency, class_name: 'Currency', foreign_key: :ask | |||
| belongs_to :bid_currency, class_name: 'Currency', foreign_key: :bid | |||
| after_commit :trigger_pusher_event | |||
| after_commit :trigger_order_event | |||
There was a problem hiding this comment.
only trigger_event
as a model norm
also we know it's an order
order.trigger_event
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
from
384a7da
to
932d54b
Compare
mnaichuk
force-pushed
the
feature/remove-useless-workers
branch
from
932d54b
to
1c8ab98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.