Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QuickJS column line support #84

Closed
1 task done
andycall opened this issue Oct 21, 2022 · 0 comments · Fixed by #116
Closed
1 task done

Add QuickJS column line support #84

andycall opened this issue Oct 21, 2022 · 0 comments · Fixed by #116
Assignees
@ErosZy
Labels
enhancement New feature or request

Comments

@andycall
Copy link
Member

Should this be an RFC?

  • This is not a substantial change

Description

If a js error is fired by QuickJS, we can only collect call stack frames and line number, but not the column number.

The column line support is essential if we wants to enable source map support for our JavaScript Debugger, otherwise the minified JavaScript code can't be debugged because all codes are in one line and column line info is missing.

Alternatives and Workarounds

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErosZy ErosZy

Labels
enhancement New feature or request
Projects
80% Completion Progresses
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add quickjs column number support openwebf/webf
2 participants
@ErosZy @andycall